From 33cc9bbc4dce9284eed41f42e338cdf25e8c8b93 Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Wed, 3 Jun 2026 23:09:31 -0700 Subject: [PATCH] xfs_scrub: bitmap iteration functions must retur bitmap_iterate doesn't generate its own errors, so don't invert the sign of the errors returned from retry_deferred_inode_range. This keeps them all positive, which is something that Codex is good at noticing and I'm not. :P Cc: linux-xfs@vger.kernel.org # v6.10.0 Fixes: 5a30504f0c60e1 ("xfs_scrub: defer phase5 file scans if dirloop fails") Signed-off-by: "Darrick J. Wong" Reviewed-by: Andrey Albershteyn --- scrub/phase5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scrub/phase5.c b/scrub/phase5.c index 52bbbca4..329d208d 100644 --- a/scrub/phase5.c +++ b/scrub/phase5.c @@ -527,7 +527,7 @@ retry_deferred_inodes( ncs->new_deferred = NULL; ncs->fixed_something = false; - error = -bitmap_iterate(ncs->cur_deferred, + error = bitmap_iterate(ncs->cur_deferred, retry_deferred_inode_range, ncs); if (error) return error; @@ -546,7 +546,7 @@ retry_deferred_inodes( ncs->new_deferred = NULL; ncs->last_call = true; - error = -bitmap_iterate(ncs->cur_deferred, + error = bitmap_iterate(ncs->cur_deferred, retry_deferred_inode_range, ncs); if (error) return error; -- 2.47.3