From 34da2a118517ef5031795f3d73fc80877e50599d Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Tue, 20 Oct 2020 18:33:29 +0800 Subject: [PATCH] pybind/mgr/dashboard: refactor overlong statement to silence lint warning like: services/tcmu_service.py:64:39: E126 continuation line over-indented for hanging indent':'./services/tcmu_service.py:64:39: E126 continuation line over-indented for hanging indent'} 2: 1 E126 continuation line over-indented for hanging indent Signed-off-by: Kefu Chai --- src/pybind/mgr/dashboard/services/tcmu_service.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/pybind/mgr/dashboard/services/tcmu_service.py b/src/pybind/mgr/dashboard/services/tcmu_service.py index 3ded28f9d2d..2cc8cffebed 100644 --- a/src/pybind/mgr/dashboard/services/tcmu_service.py +++ b/src/pybind/mgr/dashboard/services/tcmu_service.py @@ -59,9 +59,13 @@ class TcmuService(object): pool=metadata['pool_name'], name=metadata['image_name']) perf_key = "{}lock_acquired_time".format(perf_key_prefix) - lock_acquired_time = (mgr.get_counter( - 'tcmu-runner', service_id, perf_key)[perf_key] - or [[0, 0]])[-1][1] / 1000000000 + perf_value = mgr.get_counter('tcmu-runner', + service_id, + perf_key)[perf_key] + if perf_value: + lock_acquired_time = perf_value[-1][1] / 1000000000 + else: + lock_acquired_time = 0 if lock_acquired_time > image.get('optimized_since', 0): image['optimized_daemon'] = hostname image['optimized_since'] = lock_acquired_time -- 2.39.5