From 36a7dc30a6263ae0a034688fe6b1da8e0ac9a64b Mon Sep 17 00:00:00 2001
From: Igor Fedotov <ifedotov@suse.com>
Date: Mon, 23 Nov 2020 15:29:32 +0300
Subject: [PATCH] blk: log is_valid_io() parameters when unsuccessful.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
---
 src/blk/BlockDevice.cc | 17 +++++++++++++++++
 src/blk/BlockDevice.h  |  8 +-------
 2 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/src/blk/BlockDevice.cc b/src/blk/BlockDevice.cc
index 345d51fdb09f5..6804ee50cbcaa 100644
--- a/src/blk/BlockDevice.cc
+++ b/src/blk/BlockDevice.cc
@@ -196,3 +196,20 @@ void BlockDevice::reap_ioc()
     --ioc_reap_count;
   }
 }
+
+bool BlockDevice::is_valid_io(uint64_t off, uint64_t len) const {
+  bool ret = (off % block_size == 0 &&
+    len % block_size == 0 &&
+    len > 0 &&
+    off < size &&
+    off + len <= size);
+
+  if (!ret) {
+    derr << __func__ << " " << std::hex
+         << off << "~" << len
+         << " block_size " << block_size
+         << " size " << size
+         << std::dec << dendl;
+  }
+  return ret;
+}
diff --git a/src/blk/BlockDevice.h b/src/blk/BlockDevice.h
index 8ed53e69266c7..191eb8ec908af 100644
--- a/src/blk/BlockDevice.h
+++ b/src/blk/BlockDevice.h
@@ -272,13 +272,7 @@ public:
   virtual void close() = 0;
 
 protected:
-  bool is_valid_io(uint64_t off, uint64_t len) const {
-    return (off % block_size == 0 &&
-            len % block_size == 0 &&
-            len > 0 &&
-            off < size &&
-            off + len <= size);
-  }
+  bool is_valid_io(uint64_t off, uint64_t len) const;
 };
 
 #endif //CEPH_BLK_BLOCKDEVICE_H
-- 
2.39.5