From 370bddb301ff3d2da59c4cdc6b7eaed44a8cd488 Mon Sep 17 00:00:00 2001 From: Sebastian Wagner Date: Wed, 22 Apr 2020 16:10:27 +0200 Subject: [PATCH] mgr/cephadm: use check_call for `ssh-keygen` Mainly to provide any reasonable error Fixes: https://tracker.ceph.com/issues/44832 Signed-off-by: Sebastian Wagner --- src/pybind/mgr/cephadm/module.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py index 2a1ff2db642..130377ecdc5 100644 --- a/src/pybind/mgr/cephadm/module.py +++ b/src/pybind/mgr/cephadm/module.py @@ -1424,7 +1424,7 @@ class CephadmOrchestrator(orchestrator.Orchestrator, MgrModule): tmp_dir = TemporaryDirectory() path = tmp_dir.name + '/key' try: - subprocess.call([ + subprocess.check_call([ '/usr/bin/ssh-keygen', '-C', 'ceph-%s' % self._cluster_fsid, '-N', '', -- 2.39.5