From 39eabe530509312872a5cddd7ab180964a5996b9 Mon Sep 17 00:00:00 2001
From: Ankush Behl <cloudbehl@gmail.com>
Date: Tue, 14 Oct 2025 16:09:45 +0530
Subject: [PATCH] monitoring: Fixes for smb overview

Fixes: https://tracker.ceph.com/issues/73535

Signed-off-by: Ankush Behl <cloudbehl@gmail.com>
---
 monitoring/ceph-mixin/dashboards_out/smb-overview.json | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/monitoring/ceph-mixin/dashboards_out/smb-overview.json b/monitoring/ceph-mixin/dashboards_out/smb-overview.json
index 0642ccdbaa3fb..3d17426bcbda2 100644
--- a/monitoring/ceph-mixin/dashboards_out/smb-overview.json
+++ b/monitoring/ceph-mixin/dashboards_out/smb-overview.json
@@ -715,7 +715,7 @@
                   "mode": "absolute",
                   "steps": []
                },
-               "unit": "decbytes"
+               "unit": "bytes"
             },
             "overrides": []
          },
@@ -751,7 +751,7 @@
                   "uid": "${datasource}"
                },
                "editorMode": "code",
-               "expr": "rate(smb_smb2_request_inbytes{instance=~\"$hostname\", share=~\"$share\", client=~\"$client\"}[$__rate_interval])",
+               "expr": "sum by (operation) (rate(smb_smb2_request_inbytes{instance=~\"$hostname\", share=~\"$share\", client=~\"$client\"}[$__rate_interval]))",
                "format": "time_series",
                "instant": false,
                "intervalFactor": 1,
@@ -764,7 +764,7 @@
                   "uid": "${datasource}"
                },
                "editorMode": "code",
-               "expr": "rate(smb_smb2_request_outbytes{instance=~\"$hostname\", share=~\"$share\", client=~\"$client\"}[$__rate_interval])",
+               "expr": "sum by (operation) (rate(smb_smb2_request_outbytes{instance=~\"$hostname\", share=~\"$share\", client=~\"$client\"}[$__rate_interval]))",
                "format": "time_series",
                "hide": false,
                "instant": false,
@@ -862,7 +862,7 @@
                   "uid": "${datasource}"
                },
                "editorMode": "code",
-               "expr": "rate(smb_smb2_request_total{instance=~\"$hostname\", share=~\"$share\", client=~\"$client\"}[$__rate_interval])",
+               "expr": "sum by (operation) (rate(smb_smb2_request_total{instance=~\"$hostname\", share=~\"$share\", client=~\"$client\"}[$__rate_interval]))",
                "format": "time_series",
                "instant": false,
                "intervalFactor": 1,
@@ -959,7 +959,7 @@
                   "uid": "${datasource}"
                },
                "editorMode": "code",
-               "expr": "rate(smb_smb2_request_duration_microseconds_sum{instance=~\"$hostname\", share=~\"$share\", client=~\"$client\"}[$__rate_interval])",
+               "expr": "sum by (operation) (rate(smb_smb2_request_duration_microseconds_sum{instance=~\"$hostname\", share=~\"$share\", client=~\"$client\"}[$__rate_interval]))",
                "format": "time_series",
                "instant": false,
                "intervalFactor": 1,
-- 
2.39.5