From 3a43a6e130998cc97c19b49946c22c98cdfcf15b Mon Sep 17 00:00:00 2001 From: Samuel Just Date: Tue, 4 May 2021 22:22:18 -0700 Subject: [PATCH] seastore: add comment to do_transaction outlining ordering TODO Signed-off-by: Samuel Just --- src/crimson/os/seastore/seastore.cc | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/crimson/os/seastore/seastore.cc b/src/crimson/os/seastore/seastore.cc index 191ca502ee427..ee0b791658719 100644 --- a/src/crimson/os/seastore/seastore.cc +++ b/src/crimson/os/seastore/seastore.cc @@ -556,6 +556,15 @@ seastar::future<> SeaStore::do_transaction( CollectionRef _ch, ceph::os::Transaction&& _t) { + /* TODO: add ordering to Collection + * + * TransactionManager::submit_transction will ensure that + * beginning at that point operations remain ordered through + * to the jorunal. We still need a pipeline stage associated + * with each collection to ensure that this portion in + * SeaStore::do_transaction remains correctly ordered for operations + * submitted on the same collection. TODO + */ return repeat_with_internal_context( _ch, std::move(_t), -- 2.39.5