From 3a7ad1b89dfc5df5f29bad6424c08d0f4f306686 Mon Sep 17 00:00:00 2001
From: Greg Farnum <gregf@hq.newdream.net>
Date: Wed, 9 Dec 2009 16:19:27 -0800
Subject: [PATCH] msgr: Fix blocking locks and another potential block.

---
 src/msg/SimpleMessenger.cc | 8 +++++---
 src/msg/SimpleMessenger.h  | 9 +++------
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/msg/SimpleMessenger.cc b/src/msg/SimpleMessenger.cc
index 17841c9ac8738..d1eb84a7c3e15 100644
--- a/src/msg/SimpleMessenger.cc
+++ b/src/msg/SimpleMessenger.cc
@@ -260,16 +260,17 @@ void SimpleMessenger::Accepter::stop()
 void SimpleMessenger::Endpoint::dispatch_entry()
 {
   dout(0) << "entered SimpleMessenger::Endpoint::dispatch_entry" << dendl;
-  map<int, xlist<Pipe *> >::reverse_iterator high_iter;
   endpoint_lock.Lock();
   while (!stop) {
     dout(0) << "in outer !stop loop of SimpleMessenger::Endpoint::dispatch_entry" << dendl;
     while (!queued_pipes.empty()) {
       dout(0) << "SimpleMessenger::Endpoint::dispatch_entry delivering a message qlen " << qlen << dendl;
       //get highest-priority pipe
-      high_iter = queued_pipes.rbegin();
+      map<int, xlist<Pipe *> >::reverse_iterator high_iter =
+	queued_pipes.rbegin();
       int priority = high_iter->first;
       xlist<Pipe *>& pipe_list = high_iter->second;
+
       Pipe *pipe = pipe_list.front();
       dout(0) << "high priority: " << priority << " taking pipe " << pipe << dendl;
       //move pipe to back of line -- or just take off if no more messages
@@ -327,7 +328,8 @@ void SimpleMessenger::Endpoint::dispatch_entry()
       }
       endpoint_lock.Lock();
     }
-    cond.Wait(endpoint_lock); //wait for something to get put on queue
+    if (!stop)
+      cond.Wait(endpoint_lock); //wait for something to get put on queue
   }
   endpoint_lock.Unlock();
   dout(15) << "dispatch: ending loop " << dendl;
diff --git a/src/msg/SimpleMessenger.h b/src/msg/SimpleMessenger.h
index c41972cdaf999..2f1a5aa6e6f1e 100644
--- a/src/msg/SimpleMessenger.h
+++ b/src/msg/SimpleMessenger.h
@@ -344,23 +344,20 @@ private:
     void queue_connect(Connection *con) {
       endpoint_lock.Lock();
       connect_q.push_back(con);
-      local_delivery((Message*)D_CONNECT, CEPH_MSG_PRIO_HIGHEST);
-      cond.Signal();
       endpoint_lock.Unlock();
+      local_delivery((Message*)D_CONNECT, CEPH_MSG_PRIO_HIGHEST);
     }
     void queue_remote_reset(Connection *con) {
       endpoint_lock.Lock();
       remote_reset_q.push_back(con);
-      local_delivery((Message*)D_BAD_REMOTE_RESET, CEPH_MSG_PRIO_HIGHEST);
-      cond.Signal();
       endpoint_lock.Unlock();
+      local_delivery((Message*)D_BAD_REMOTE_RESET, CEPH_MSG_PRIO_HIGHEST);
     }
     void queue_reset(Connection *con) {
       endpoint_lock.Lock();
+      endpoint_lock.Unlock();
       reset_q.push_back(con);
       local_delivery((Message*)D_BAD_RESET, CEPH_MSG_PRIO_HIGHEST);
-      cond.Signal();
-      endpoint_lock.Unlock();
     }
 
   public:
-- 
2.39.5