From 3b77687c42598c721cf98e3f27158bb4f8fa9d10 Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Thu, 7 Feb 2013 19:55:52 +0100 Subject: [PATCH] common/AsyncReserver.h: use empty() instead of size() Fix warning for usage of queue.size() in do_queues(). Use empty() since it should be prefered as it has, following the standard, a constant time complexity regardless of the containter type. The same is not guaranteed for size(). warning from cppchecker was: [common/AsyncReserver.h:40]: (performance) Possible inefficient checking for 'queue' emptiness. Signed-off-by: Danny Al-Gaaf --- src/common/AsyncReserver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/AsyncReserver.h b/src/common/AsyncReserver.h index 8cc2258d7b473..638bfb3a1b1a8 100644 --- a/src/common/AsyncReserver.h +++ b/src/common/AsyncReserver.h @@ -37,7 +37,7 @@ class AsyncReserver { void do_queues() { while (in_progress.size() < max_allowed && - queue.size()) { + !queue.empty()) { pair p = queue.front(); queue_pointers.erase(p.first); queue.pop_front(); -- 2.39.5