From 3c2f33221ccafbc4f8d0151e344edbe5cc728635 Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Thu, 17 May 2018 17:29:20 +0200 Subject: [PATCH] take-over: fix bug when trying to override variable A customer has been facing an issue when trying to override `monitor_interface` in inventory host file. In his use case, all nodes had the same interface for `monitor_interface` name except one. Therefore, they tried to override this variable for that node in the inventory host file but the take-over-existing-cluster playbook was failing when trying to generate the new ceph.conf file because of undefined variable. Typical error: ``` fatal: [srvcto103cnodep01]: FAILED! => {"failed": true, "msg": "'dict object' has no attribute u'ansible_bond0.15'"} ``` Including variables like this `include_vars: group_vars/all.yml` prevent us from overriding anything in inventory host file because it overwrites everything you would have defined in inventory. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1575915 Signed-off-by: Guillaume Abrioux (cherry picked from commit 415dc0a29b10b28cbd047fe28eb4dd38419ea5dc) Signed-off-by: Guillaume Abrioux --- infrastructure-playbooks/take-over-existing-cluster.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/infrastructure-playbooks/take-over-existing-cluster.yml b/infrastructure-playbooks/take-over-existing-cluster.yml index 0dcc1870f..0da650986 100644 --- a/infrastructure-playbooks/take-over-existing-cluster.yml +++ b/infrastructure-playbooks/take-over-existing-cluster.yml @@ -34,10 +34,10 @@ - iscsi-gw become: true - tasks: - - include_vars: roles/ceph-defaults/defaults/main.yml - - include_vars: group_vars/all.yml + roles: + - ceph-defaults + post_tasks: - name: get the name of the existing ceph cluster shell: | basename $(grep --exclude '*.bak' -R fsid /etc/ceph/ | egrep -o '^[^.]*' | head -n 1) -- 2.39.5