From 3d7d7d1f3332041c88bbd73439a69943fc124e87 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Tue, 4 May 2010 09:51:36 -0700 Subject: [PATCH] osdmaptool: add -h; don't assert on bad filename --- src/osdmaptool.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/osdmaptool.cc b/src/osdmaptool.cc index 21d34c0a01ff4..1da08816b7e88 100644 --- a/src/osdmaptool.cc +++ b/src/osdmaptool.cc @@ -66,7 +66,9 @@ int main(int argc, const char **argv) bool test_crush = false; FOR_EACH_ARG(args) { - if (CONF_ARG_EQ("print", 'p')) { + if (CONF_ARG_EQ("help", 'h')) { + usage(); + } else if (CONF_ARG_EQ("print", 'p')) { CONF_SAFE_SET_ARG_VAL(&print, OPT_BOOL); } else if (CONF_ARG_EQ("createsimple", '\0')) { createsimple = true; @@ -107,7 +109,8 @@ int main(int argc, const char **argv) int r = 0; if (!(createsimple && clobber)) { r = bl.read_file(fn); - osdmap.decode(bl); + if (r >= 0) + osdmap.decode(bl); } char buf[80]; if (!createsimple && r < 0) { -- 2.39.5