From 3e8e6c6659882fed60339b10f0af35da04f3c84f Mon Sep 17 00:00:00 2001 From: Afreen Misbah Date: Mon, 16 Jun 2025 20:46:39 +0530 Subject: [PATCH] mgr/dashboard: Add --force flag for listeners Fixes https://tracker.ceph.com/issues/71685 Signed-off-by: Afreen Misbah (cherry picked from commit 604d351a4e7bbf47baf57e10f67219a2eea919e0) --- .../nvmeof-listeners-list/nvmeof-listeners-list.component.ts | 1 + .../frontend/src/app/shared/api/nvmeof.service.spec.ts | 2 +- .../dashboard/frontend/src/app/shared/api/nvmeof.service.ts | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-listeners-list/nvmeof-listeners-list.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-listeners-list/nvmeof-listeners-list.component.ts index b79dc51a88fcc..14f96e09eec9c 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-listeners-list/nvmeof-listeners-list.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-listeners-list/nvmeof-listeners-list.component.ts @@ -102,6 +102,7 @@ export class NvmeofListenersListComponent implements OnInit { this.modalService.show(DeleteConfirmationModalComponent, { itemDescription: $localize`Listener`, actionDescription: 'delete', + infoMessage: $localize`This action will delete listener despite any active connections.`, itemNames: [ $localize`listener` + ' ' + `${listener.host_name} (${listener.traddr}:${listener.trsvcid})` ], diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.spec.ts index 6eaff6509e25e..861d49008b1d0 100755 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.spec.ts @@ -133,7 +133,7 @@ describe('NvmeofService', () => { .deleteListener(mockNQN, mockGroupName, request.host_name, request.traddr, request.trsvcid) .subscribe(); const req = httpTesting.expectOne( - `${API_PATH}/subsystem/${mockNQN}/listener/${request.host_name}/${request.traddr}?gw_group=${mockGroupName}&trsvcid=${request.trsvcid}` + `${API_PATH}/subsystem/${mockNQN}/listener/${request.host_name}/${request.traddr}?gw_group=${mockGroupName}&trsvcid=${request.trsvcid}&force=true` ); expect(req.request.method).toBe('DELETE'); }); diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.ts index b68562bfed311..7925bfd96491a 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/nvmeof.service.ts @@ -157,7 +157,8 @@ export class NvmeofService { observe: 'response', params: { gw_group: group, - trsvcid + trsvcid, + force: 'true' } } ); -- 2.39.5