From 3ea5242e381a850c080ee9edbaeea28059ad4da9 Mon Sep 17 00:00:00 2001
From: Kefu Chai <kchai@redhat.com>
Date: Wed, 26 May 2021 09:10:05 +0800
Subject: [PATCH] vstart: define helper for parsing block_devs options

for better readability, and to simplify the code

Signed-off-by: Kefu Chai <kchai@redhat.com>
---
 src/vstart.sh | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/vstart.sh b/src/vstart.sh
index 260a33302d520..f5f5e8bfc0a8a 100755
--- a/src/vstart.sh
+++ b/src/vstart.sh
@@ -248,6 +248,18 @@ usage_exit() {
     exit
 }
 
+parse_block_devs() {
+    local opt_name=$1
+    shift
+    IFS=',' read -r -a block_devs <<< "$2"
+    for dev in "${block_devs[@]}"; do
+        if [ ! -b $dev -o ! -w $dev ]; then
+            echo "All $opt_name must refer to writable block devices"
+            exit 1
+        fi
+    done
+}
+
 while [ $# -ge 1 ]; do
 case $1 in
     -d | --debug)
@@ -437,13 +449,7 @@ case $1 in
         with_mgr_dashboard=false
         ;;
     --seastore-devs)
-        IFS=',' read -r -a block_devs <<< "$2"
-        for dev in "${block_devs[@]}"; do
-            if [ ! -b $dev -o ! -w $dev ]; then
-                echo "All --seastore-devs must refer to writable block devices"
-                exit 1
-            fi
-        done
+        parse_block_devs --seastore-devs
         shift
         ;;
     --bluestore-spdk)
@@ -453,13 +459,7 @@ case $1 in
         shift
         ;;
     --bluestore-devs)
-        IFS=',' read -r -a block_devs <<< "$2"
-        for dev in "${block_devs[@]}"; do
-            if [ ! -b $dev -o ! -w $dev ]; then
-                echo "All --bluestore-devs must refer to writable block devices"
-                exit 1
-            fi
-        done
+        parse_block_devs --bluestore-devs
         shift
         ;;
     --bluestore-zoned)
-- 
2.39.5