From 3ebb5cc7c61daed0c78b6dc87681a3e4dc56ab5f Mon Sep 17 00:00:00 2001 From: tangwenjun Date: Wed, 24 Jan 2018 15:23:42 +0800 Subject: [PATCH] os/bluestore.cc: no need to fsync when failed to write label Signed-off-by: tangwenjun --- src/os/bluestore/BlueStore.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc index a2599f400898d..5ec86ea91a88b 100644 --- a/src/os/bluestore/BlueStore.cc +++ b/src/os/bluestore/BlueStore.cc @@ -4160,12 +4160,14 @@ int BlueStore::_write_bdev_label(CephContext *cct, if (r < 0) { derr << __func__ << " failed to write to " << path << ": " << cpp_strerror(r) << dendl; + goto out; } r = ::fsync(fd); if (r < 0) { derr << __func__ << " failed to fsync " << path << ": " << cpp_strerror(r) << dendl; } +out: VOID_TEMP_FAILURE_RETRY(::close(fd)); return r; } -- 2.39.5