From 3f47c2293b9ace730d6f76c613ef2106f274ea32 Mon Sep 17 00:00:00 2001 From: Sebastian Wagner Date: Thu, 16 Dec 2021 17:57:50 +0100 Subject: [PATCH] mgr/cephadm: SNMP: don't write urls manually this just broken for non-trivial urls. Don't be a bad example Signed-off-by: Sebastian Wagner --- src/pybind/mgr/cephadm/services/monitoring.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pybind/mgr/cephadm/services/monitoring.py b/src/pybind/mgr/cephadm/services/monitoring.py index c252462c212..d67d3057bb8 100644 --- a/src/pybind/mgr/cephadm/services/monitoring.py +++ b/src/pybind/mgr/cephadm/services/monitoring.py @@ -158,7 +158,9 @@ class AlertmanagerService(CephadmService): assert dd.ports addr = dd.ip if dd.ip else self._inventory_get_addr(dd.hostname) deps.append(dd.name()) - snmp_gateway_urls.append(f"http://{addr}:{dd.ports[0]}/alerts") + + snmp_gateway_urls.append(build_url(scheme='http', host=addr, + port=dd.ports[0], path='/alerts')) context = { 'dashboard_urls': dashboard_urls, -- 2.39.5