From 3f4bd46735a574a92ded4f9a40738d56a4202b0e Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Tue, 29 Dec 2015 13:10:17 -0500 Subject: [PATCH] os/bluestore/BlueFS: fix leak of iocs in writer Signed-off-by: Sage Weil --- src/os/bluestore/BlueFS.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/os/bluestore/BlueFS.h b/src/os/bluestore/BlueFS.h index e682dec1121eb..cbdefff3c00ed 100644 --- a/src/os/bluestore/BlueFS.h +++ b/src/os/bluestore/BlueFS.h @@ -67,16 +67,12 @@ public: bufferlist tail_block; ///< existing partial block at end of file, if any Mutex lock; - /*Cond cond; - bool num_aio_in_flight; - */ vector iocv; ///< one for each bdev FileWriter(FileRef f, unsigned num_bdev) : file(f), pos(0), - lock("BlueFS::FileWriter::lock") { //, - //num_aio_in_flight(0) { + lock("BlueFS::FileWriter::lock") { file->num_writers.inc(); iocv.resize(num_bdev); for (unsigned i = 0; i < num_bdev; ++i) { @@ -85,6 +81,9 @@ public: } ~FileWriter() { file->num_writers.dec(); + for (auto p : iocv) { + delete p; + } } void append(const char *buf, size_t len) { -- 2.39.5