From 3fad65cdbe079321c4732c7feb3a806cc3aa75e8 Mon Sep 17 00:00:00 2001 From: Nizamudeen A Date: Tue, 12 Aug 2025 09:45:54 +0530 Subject: [PATCH] mgr/dashboard: close token status subscription properly Since its not returning any subscription back to the `this.subs` property, those subscriptions are not properly closed in the workbench-layout when its destroyed. So ensuring proper return Fixes: https://tracker.ceph.com/issues/72530 Signed-off-by: Nizamudeen A (cherry picked from commit 79729c4ece92d5fdd2f5bed50c203a1a7077be14) --- .../frontend/src/app/shared/api/multi-cluster.service.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/multi-cluster.service.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/multi-cluster.service.ts index 0aa57437f25..e17c1a741aa 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/api/multi-cluster.service.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/api/multi-cluster.service.ts @@ -33,12 +33,12 @@ export class MultiClusterService { } startClusterTokenStatusPolling() { - this.checkAndStartTimer(); + return this.checkAndStartTimer(); } private checkAndStartTimer() { this.checkTokenStatus().subscribe(this.getClusterTokenStatusObserver()); - this.timerService + return this.timerService .get(() => this.checkTokenStatus(), this.TOKEN_CHECK_INTERVAL) .subscribe(this.getClusterTokenStatusObserver()); } -- 2.39.5