From 3fd13f57edbf9f6ee6d9591f95f9691708754e10 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Fri, 24 Aug 2012 19:27:55 -0700 Subject: [PATCH] crypto: fix fd leak from get_random_bytes() Signed-off-by: Sage Weil --- src/auth/Crypto.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/auth/Crypto.cc b/src/auth/Crypto.cc index ec73b1e8e1549..a142b7f62e97b 100644 --- a/src/auth/Crypto.cc +++ b/src/auth/Crypto.cc @@ -42,10 +42,8 @@ int get_random_bytes(char *buf, int len) if (fd < 0) return -errno; int ret = safe_read_exact(fd, buf, len); - if (ret) - return ret; TEMP_FAILURE_RETRY(::close(fd)); - return 0; + return ret; } static int get_random_bytes(int len, bufferlist& bl) -- 2.39.5