From 3ff47c7f3eb5964464c8cd49144546ce532ed7f7 Mon Sep 17 00:00:00 2001 From: Matt Benjamin Date: Wed, 16 May 2018 13:04:55 -0400 Subject: [PATCH] rgw: require --yes-i-really-mean-it to run radosgw-admin orphans find Incorrect use of orphans find can lead to data loss. Warn users to be extra cautious. Fixes: http://tracker.ceph.com/issues/24146 Signed-off-by: Matt Benjamin --- src/rgw/rgw_admin.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/rgw/rgw_admin.cc b/src/rgw/rgw_admin.cc index f9bfc861d8313..e27ae1055af39 100644 --- a/src/rgw/rgw_admin.cc +++ b/src/rgw/rgw_admin.cc @@ -6362,6 +6362,13 @@ next: } if (opt_cmd == OPT_ORPHANS_FIND) { + if (!yes_i_really_mean_it) { + cerr << "accidental removal of active objects can not be reversed; " + << "do you really mean it? (requires --yes-i-really-mean-it)" + << std::endl; + return EINVAL; + } + RGWOrphanSearch search(store, max_concurrent_ios, orphan_stale_secs); if (job_id.empty()) { -- 2.39.5