From 42a9beee0741aaea2efeebc1d8bce956a2c5ff63 Mon Sep 17 00:00:00 2001 From: Kotresh HR Date: Thu, 18 Sep 2025 06:41:11 +0000 Subject: [PATCH] cephfs-journal-tool:: Don't reset the journal trim position If the fs had to go through journal recovery and reset, the cephfs-journal-tool resets the journal trim position because of which the old unused journal objects just stay forever in the metadata pool. The patch fixes the issue. Now, the old stale journal objects are trimmed during the regular trimming cycle helping to recover space in the metadata pool. Fixes: https://tracker.ceph.com/issues/69708 Signed-off-by: Kotresh HR (cherry picked from commit 4f9a926a467c03a410e5ec5a81031e72f2193f25) --- src/tools/cephfs/Resetter.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/tools/cephfs/Resetter.cc b/src/tools/cephfs/Resetter.cc index 92996fd968507..33d3b57a91dcb 100644 --- a/src/tools/cephfs/Resetter.cc +++ b/src/tools/cephfs/Resetter.cc @@ -119,7 +119,6 @@ int Resetter::reset() journaler.set_read_pos(new_start); journaler.set_write_pos(new_start); journaler.set_expire_pos(new_start); - journaler.set_trimmed_pos(new_start); journaler.set_writeable(); cout << "writing journal head" << std::endl; -- 2.39.5