From 42b5c4dd8f71a32f1b0ae1bb950f6e690f2c66e1 Mon Sep 17 00:00:00 2001
From: Sage Weil <sage@redhat.com>
Date: Thu, 31 Jan 2019 14:05:37 -0600
Subject: [PATCH] mon/MonClient: finsih authenticate() only after we get
 monmap; fix 'tell mgr'

We used to get a valid monmap before we finished the MAuth exchange and
returned from authenticate().  Now, we finish authenticating before we even
send or receive a message, so authenticate() returns quickly.  This
confuses many callers, and is probably a bad idea.  So, rejigger the
_finish_auth and _finish_hunting callers so that we finish hunting as soon
as we have picked a mon but don't finish_auth if we have not gotten our
first monmap.

Signed-off-by: Sage Weil <sage@redhat.com>
---
 src/mon/MonClient.cc | 41 ++++++++++++++++++++++++++---------------
 1 file changed, 26 insertions(+), 15 deletions(-)

diff --git a/src/mon/MonClient.cc b/src/mon/MonClient.cc
index ac7922c3153..3ed28052f5e 100644
--- a/src/mon/MonClient.cc
+++ b/src/mon/MonClient.cc
@@ -414,6 +414,10 @@ void MonClient::handle_monmap(MMonMap *m)
   sub.got("monmap", monmap.get_epoch());
   map_cond.Signal();
   want_monmap = false;
+
+  if (authenticate_err == 1) {
+    _finish_auth(0);
+  }
 }
 
 void MonClient::handle_config(MConfig *m)
@@ -527,8 +531,8 @@ int MonClient::authenticate(double timeout)
   until += timeout;
   if (timeout > 0.0)
     ldout(cct, 10) << "authenticate will time out at " << until << dendl;
-  authenticate_err = 0;
-  while (!active_con && !authenticate_err) {
+  authenticate_err = 1;  // == in progress
+  while (!active_con && authenticate_err >= 0) {
     if (timeout > 0.0) {
       int r = auth_cond.WaitUntil(monc_lock, until);
       if (r == ETIMEDOUT && !active_con) {
@@ -544,7 +548,7 @@ int MonClient::authenticate(double timeout)
     ldout(cct, 5) << __func__ << " success, global_id "
 		  << active_con->get_global_id() << dendl;
     // active_con should not have been set if there was an error
-    ceph_assert(authenticate_err == 0);
+    ceph_assert(authenticate_err >= 0);
     authenticated = true;
   }
 
@@ -597,10 +601,12 @@ void MonClient::handle_auth(MAuthReply *m)
   }
 
   _finish_hunting(auth_err);
+  _finish_auth(auth_err);
 }
 
 void MonClient::_finish_auth(int auth_err)
 {
+  ldout(cct,10) << __func__ << " " << auth_err << dendl;
   authenticate_err = auth_err;
   // _resend_mon_commands() could _reopen_session() if the connected mon is not
   // the one the MonCommand is targeting.
@@ -609,6 +615,18 @@ void MonClient::_finish_auth(int auth_err)
     _check_auth_tickets();
   }
   auth_cond.SignalAll();
+
+  if (!auth_err) {
+    Context *cb = nullptr;
+    if (session_established_context) {
+      cb = session_established_context.release();
+    }
+    if (cb) {
+      monc_lock.Unlock();
+      cb->complete(0);
+      monc_lock.Lock();
+    }
+  }
 }
 
 // ---------
@@ -761,6 +779,7 @@ void MonClient::_start_hunting()
 
 void MonClient::_finish_hunting(int auth_err)
 {
+  ldout(cct,10) << __func__ << " " << auth_err << dendl;
   ceph_assert(monc_lock.is_locked());
   // the pending conns have been cleaned.
   ceph_assert(!_hunting());
@@ -793,18 +812,6 @@ void MonClient::_finish_hunting(int auth_err)
       global_id = active_con->get_global_id();
     }
   }
-  _finish_auth(auth_err);
-  if (!auth_err) {
-    Context *cb = nullptr;
-    if (session_established_context) {
-      cb = session_established_context.release();
-    }
-    if (cb) {
-      monc_lock.Unlock();
-      cb->complete(0);
-      monc_lock.Lock();
-    }
-  }
 }
 
 void MonClient::tick()
@@ -1323,6 +1330,9 @@ int MonClient::handle_auth_done(
 	}
 
 	_finish_hunting(r);
+	if (r || monmap.get_epoch() > 0) {
+	  _finish_auth(r);
+	}
 	return r;
       }
     }
@@ -1367,6 +1377,7 @@ int MonClient::handle_auth_bad_method(
 	}
 	// fail hunt
 	_finish_hunting(r);
+	_finish_auth(r);
 	return r;
       }
     }
-- 
2.39.5