From 4380e4df7919a3397703e849310eaf9d949b94e0 Mon Sep 17 00:00:00 2001 From: Zhao Lei Date: Tue, 4 Aug 2015 14:10:49 +1000 Subject: [PATCH] check: Make -g and -x option meet description in manual In manual: # ./check --help ... -g group[,group...] include tests from these groups -x group[,group...] exclude tests from these groups ... Above format is not supported, because ',' is not parsed in code. This patch fixed it. Before patch: # ./check -g scrub,replace Group "scrub,replace" is empty or not defined? After patch: # ./check -g scrub,replace FSTYP -- btrfs PLATFORM -- Linux/x86_64 kerneldev 4.2.0-rc2_HEAD_c65b99f046843d2455aa231747b5a07a999a9f3d_+ MKFS_OPTIONS -- /dev/vdd MOUNT_OPTIONS -- /dev/vdd /var/ltf/tester/scratch_mnt ...(right result)... Signed-off-by: Zhao Lei Reviewed-by: Eryu Guan Signed-off-by: Dave Chinner --- check | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/check b/check index 866b7066..4307a330 100755 --- a/check +++ b/check @@ -209,11 +209,11 @@ while [ $# -gt 0 ]; do -tmpfs) FSTYP=tmpfs ;; -g) group=$2 ; shift ; - GROUP_LIST="$GROUP_LIST $group" + GROUP_LIST="$GROUP_LIST ${group//,/ }" ;; -x) xgroup=$2 ; shift ; - XGROUP_LIST="$XGROUP_LIST $xgroup" + XGROUP_LIST="$XGROUP_LIST ${xgroup//,/ }" ;; -X) xfile=$2; shift ; -- 2.39.5