From 439ae5496252077f87e704ba8e42abc74a3321eb Mon Sep 17 00:00:00 2001 From: John Mulligan Date: Wed, 8 May 2024 13:04:01 -0400 Subject: [PATCH] mgr/smb: fix an incorrect comment At one point the comment was true but I ended doing a workaround enabling a wrapper in proto.py of typing_extensions.Self and using it here turning the comment untrue. Signed-off-by: John Mulligan --- src/pybind/mgr/smb/resources.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/pybind/mgr/smb/resources.py b/src/pybind/mgr/smb/resources.py index bbda46b2256..ea6b6585cd9 100644 --- a/src/pybind/mgr/smb/resources.py +++ b/src/pybind/mgr/smb/resources.py @@ -320,8 +320,7 @@ class WrappedPlacementSpec(PlacementSpec): # improperly typed. They are improperly typed because typing.Self # didn't exist and the old correct way is a PITA to write (and # remember). Thus a lot of classmethods are return the exact class - # which is technically incorrect. This fine class is guilty of the same - # sin. :-) + # which is technically incorrect. return cast(Self, cls.from_json(data)) @classmethod -- 2.39.5