From 47117d9f16efef606310e6eeadd676a6f4cf0e48 Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Wed, 30 Jul 2025 07:28:35 +0200 Subject: [PATCH] tools/ceph-dencoder: remove "using namespace std" MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This breaks the ARM-NEON build: /usr/lib/gcc/aarch64-linux-gnu/14/include/arm_neon.h:2632:31: error: reference to ‘float16_t’ is ambiguous 2632 | __extension__ extern __inline float16_t | ^~~~~~~~~ /usr/include/c++/14/stdfloat:40:9: note: candidates are: ‘using std::float16_t = _Float16’ 40 | using float16_t = _Float16; | ^~~~~~~~~ /usr/lib/gcc/aarch64-linux-gnu/14/include/arm_neon.h:74:16: note: ‘typedef __fp16 float16_t’ 74 | typedef __fp16 float16_t; | ^~~~~~~~~ Signed-off-by: Max Kellermann --- src/tools/ceph-dencoder/common_types.cc | 1 - src/tools/ceph-dencoder/mds_types.cc | 1 - src/tools/ceph-dencoder/nvmeof_types.cc | 1 - src/tools/ceph-dencoder/osd_types.cc | 1 - src/tools/ceph-dencoder/rbd_types.cc | 1 - src/tools/ceph-dencoder/rgw_types.cc | 1 - src/tools/ceph-dencoder/str.h | 2 +- 7 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/tools/ceph-dencoder/common_types.cc b/src/tools/ceph-dencoder/common_types.cc index fa763c3bbd96b..7c894ab37612c 100644 --- a/src/tools/ceph-dencoder/common_types.cc +++ b/src/tools/ceph-dencoder/common_types.cc @@ -1,6 +1,5 @@ #include "acconfig.h" #include -using namespace std; #include "include/ceph_features.h" #define TYPE(t) diff --git a/src/tools/ceph-dencoder/mds_types.cc b/src/tools/ceph-dencoder/mds_types.cc index 94280477a5b56..cee0779e48ba0 100644 --- a/src/tools/ceph-dencoder/mds_types.cc +++ b/src/tools/ceph-dencoder/mds_types.cc @@ -1,6 +1,5 @@ #include "acconfig.h" #include -using namespace std; #include "include/ceph_features.h" #define TYPE(t) diff --git a/src/tools/ceph-dencoder/nvmeof_types.cc b/src/tools/ceph-dencoder/nvmeof_types.cc index 86b76e43741eb..645f8c6494a5f 100644 --- a/src/tools/ceph-dencoder/nvmeof_types.cc +++ b/src/tools/ceph-dencoder/nvmeof_types.cc @@ -1,6 +1,5 @@ #include "acconfig.h" #include -using namespace std; #include "include/ceph_features.h" #define TYPE(t) diff --git a/src/tools/ceph-dencoder/osd_types.cc b/src/tools/ceph-dencoder/osd_types.cc index 13a90685bc854..0170179a80443 100644 --- a/src/tools/ceph-dencoder/osd_types.cc +++ b/src/tools/ceph-dencoder/osd_types.cc @@ -1,6 +1,5 @@ #include "acconfig.h" #include -using namespace std; #include "include/ceph_features.h" #define TYPE(t) diff --git a/src/tools/ceph-dencoder/rbd_types.cc b/src/tools/ceph-dencoder/rbd_types.cc index e04efc30d5287..81d4fa7e5ed4d 100644 --- a/src/tools/ceph-dencoder/rbd_types.cc +++ b/src/tools/ceph-dencoder/rbd_types.cc @@ -1,6 +1,5 @@ #include "acconfig.h" #include -using namespace std; #include "include/ceph_features.h" #define TYPE(t) diff --git a/src/tools/ceph-dencoder/rgw_types.cc b/src/tools/ceph-dencoder/rgw_types.cc index 79688b5343f57..2fe444362a45b 100644 --- a/src/tools/ceph-dencoder/rgw_types.cc +++ b/src/tools/ceph-dencoder/rgw_types.cc @@ -1,6 +1,5 @@ #include "acconfig.h" #include -using namespace std; #include "include/ceph_features.h" #define TYPE(t) diff --git a/src/tools/ceph-dencoder/str.h b/src/tools/ceph-dencoder/str.h index 7ff1d0794b512..defc224c6139f 100644 --- a/src/tools/ceph-dencoder/str.h +++ b/src/tools/ceph-dencoder/str.h @@ -8,7 +8,7 @@ class string_wrapper { std::string s; public: string_wrapper() = default; - string_wrapper(string s1) + string_wrapper(std::string s1) : s(s1) {} -- 2.39.5