From 472b56e2174479a65253492455012cf43b291b20 Mon Sep 17 00:00:00 2001 From: Aashish Sharma Date: Mon, 23 Sep 2024 13:58:22 +0530 Subject: [PATCH] mgr/dashboard: fix setting compression type while editing rgw zone Fixes: https://tracker.ceph.com/issues/68176 Signed-off-by: Aashish Sharma (cherry picked from commit ff7aa420b1abc5b1ecc03804ccc6fe8bdb962704) --- src/pybind/mgr/dashboard/services/rgw_client.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pybind/mgr/dashboard/services/rgw_client.py b/src/pybind/mgr/dashboard/services/rgw_client.py index aed70260362..b39ba30479e 100644 --- a/src/pybind/mgr/dashboard/services/rgw_client.py +++ b/src/pybind/mgr/dashboard/services/rgw_client.py @@ -1492,8 +1492,9 @@ class RgwMultisite: rgw_zone_add_storage_class_cmd = ['zone', 'placement', 'add', '--rgw-zone', zone_name, '--placement-id', placement_target, '--storage-class', storage_class, - '--data-pool', data_pool, - '--compression', compression] + '--data-pool', data_pool] + if compression: + rgw_zone_add_storage_class_cmd.extend(['--compression', compression]) try: exit_code, _, err = mgr.send_rgwadmin_command(rgw_zone_add_storage_class_cmd) if exit_code > 0: -- 2.39.5