From 47514db2e6e5c79ad27181517868f8876352c449 Mon Sep 17 00:00:00 2001 From: Afreen Misbah Date: Tue, 3 Sep 2024 12:18:46 +0530 Subject: [PATCH] mgr/dashboard: Fixed bug in service form The commit in main went through this PR https://github.com/ceph/ceph/pull/59496/commits/6c25635be8c2ec0c2f637c4fe6952f781c1ad12c This PR wont be backported to squid hence adding the change in separate commit. Signed-off-by: Afreen Misbah --- .../services/service-form/service-form.component.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.ts index a37cca34014..9602c856aed 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.ts @@ -195,7 +195,12 @@ export class ServiceFormComponent extends CdForm implements OnInit { }) ] ], - group: [null, Validators.required], + group: [ + null, + CdValidators.requiredIf({ + service_type: 'nvmeof' + }) + ], // RGW rgw_frontend_port: [null, [CdValidators.number(false)]], realm_name: [null], -- 2.39.5