From 48c1e44d573ef43a798352994db7c98de287f25c Mon Sep 17 00:00:00 2001 From: "Adam C. Emerson" Date: Fri, 15 Mar 2019 15:22:05 -0400 Subject: [PATCH] rgw: Avoid signedness weirdness If `char` is signed, then every `char` will be less than 255. Thus, declare `e` as `unsigned char`. Signed-off-by: Adam C. Emerson --- src/rgw/rgw_rados.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rgw/rgw_rados.cc b/src/rgw/rgw_rados.cc index 7ae743acadc..0c5e9ceba49 100644 --- a/src/rgw/rgw_rados.cc +++ b/src/rgw/rgw_rados.cc @@ -2432,7 +2432,7 @@ int RGWRados::Bucket::update_bucket_id(const string& new_bucket_id) static inline std::string after_delim(std::string_view delim) { // assert: ! delim.empty() - char e = delim.back(); + unsigned char e = delim.back(); delim.remove_suffix(1); std::string result{delim.data(), delim.length()}; if (e < 255) { -- 2.39.5