From 48d8279dc7722f28fbba428e250baa8e4637f127 Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Wed, 10 Jul 2024 22:59:51 +0530 Subject: [PATCH] mgr/smb: Replace "clusters" with "shares" in error status In the following error response the list of active shares is incorrectly displayed with "clusters" field. { "resource": { "resource_type": "ceph.smb.cluster", "cluster_id": "smbcluster", "intent": "removed" }, "clusters": [ "smbshare" ], "msg": "cluster in use by shares", "success": false } Replace "clusters" with "shares" to avoid confusion. Signed-off-by: Anoop C S --- src/pybind/mgr/smb/handler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pybind/mgr/smb/handler.py b/src/pybind/mgr/smb/handler.py index 84702e72f78..510715bb2b6 100644 --- a/src/pybind/mgr/smb/handler.py +++ b/src/pybind/mgr/smb/handler.py @@ -758,7 +758,7 @@ def _check_cluster(cluster: ClusterRef, staging: _Staging) -> None: cluster, msg="cluster in use by shares", status={ - 'clusters': [ + 'shares': [ shid for cid, shid in share_ids if cid == cluster.cluster_id -- 2.39.5