From 48fe886bb5c255e3716e39570794aac49c34704f Mon Sep 17 00:00:00 2001 From: Nizamudeen A Date: Wed, 11 May 2022 16:17:00 +0530 Subject: [PATCH] mgr/dashboard: avoid overriding the configuration in package.json the warning in npm run build is `Option "configuration" was already specified with value "en-US". The new value "production" will override it.` This causes the dist for production env to be created in dist/ whereas it should be dist/en-US (or whatever npm_config_locale. That prevented from dashboard to load and cause the cephadm e2e checks to fail. https://jenkins.ceph.com/job/ceph-dashboard-cephadm-e2e-nightly-master/185/consoleFull#57532618373a8703b-5adb-41c5-84a0-8cf4e065ba3d Related to https://github.com/ceph/ceph/pull/46143 Signed-off-by: Nizamudeen A --- src/pybind/mgr/dashboard/ci/cephadm/start-cluster.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pybind/mgr/dashboard/ci/cephadm/start-cluster.sh b/src/pybind/mgr/dashboard/ci/cephadm/start-cluster.sh index b69e28e41ebe6..95cfd070d8ce1 100755 --- a/src/pybind/mgr/dashboard/ci/cephadm/start-cluster.sh +++ b/src/pybind/mgr/dashboard/ci/cephadm/start-cluster.sh @@ -64,7 +64,7 @@ if [[ -n "$JENKINS_HOME" ]]; then npm cache clean --force fi npm ci -FRONTEND_BUILD_OPTS='-- --configuration production' +FRONTEND_BUILD_OPTS='--configuration=production' if [[ -n "${DEV_MODE}" ]]; then FRONTEND_BUILD_OPTS+=' --deleteOutputPath=false --watch' fi -- 2.39.5