From 4938c5732d61674f0186fb64160f6bdaa65b7e6c Mon Sep 17 00:00:00 2001
From: Tatjana Dehler <tdehler@suse.com>
Date: Tue, 11 Dec 2018 09:45:30 +0100
Subject: [PATCH] mgr/dashboard: do a little clean-up of the component

- order component methods alphabetically
- add missing newline
- uncheck checkbox and clear validations if a new profile has been choosen

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
---
 .../osd-recv-speed-modal.component.html       |  1 +
 .../osd-recv-speed-modal.component.ts         | 46 ++++++++++---------
 .../frontend/src/locale/messages.xlf          |  6 +--
 3 files changed, 28 insertions(+), 25 deletions(-)

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.html
index 79dc580a756..884a1c56dae 100755
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.html
@@ -45,6 +45,7 @@
             </div>
           </div>
         </div>
+
         <!-- Priority values -->
         <div class="form-group" *ngFor="let attr of priorityAttrs | keyvalue"
              [ngClass]="{'has-error': osdRecvSpeedForm.getValue('customizePriority') &&
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.ts
index b8fd4897b29..860ad1bcf33 100755
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.ts
@@ -94,6 +94,27 @@ export class OsdRecvSpeedModalComponent implements OnInit {
       });
   }
 
+  getStoredPriority(configOptionValues: any, callbackFn: Function) {
+    const priority = _.find(this.priorities, (p) => {
+      return _.isEqual(p.values, configOptionValues);
+    });
+
+    this.osdRecvSpeedForm.controls.customizePriority.setValue(false);
+
+    if (priority) {
+      return callbackFn(priority);
+    }
+
+    if (Object.entries(configOptionValues).length === 4) {
+      this.osdRecvSpeedForm.controls.customizePriority.setValue(true);
+      return callbackFn(
+        Object({ name: 'custom', text: this.i18n('Custom'), values: configOptionValues })
+      );
+    }
+
+    return callbackFn(this.priorities[0]);
+  }
+
   setDescription(configOptions: Array<any>) {
     configOptions.forEach((configOption) => {
       if (configOption.desc !== '') {
@@ -136,37 +157,18 @@ export class OsdRecvSpeedModalComponent implements OnInit {
       };
       this.setPriority(customPriority);
     } else {
+      Object.keys(this.priorityAttrs).forEach((configOptionName) => {
+        this.osdRecvSpeedForm.get(configOptionName).reset();
+      });
       this.setPriority(this.priorities[0]);
     }
   }
 
-  getStoredPriority(configOptionValues: any, callbackFn: Function) {
-    const priority = _.find(this.priorities, (p) => {
-      return _.isEqual(p.values, configOptionValues);
-    });
-
-    this.osdRecvSpeedForm.controls.customizePriority.setValue(false);
-
-    if (priority) {
-      return callbackFn(priority);
-    }
-
-    if (Object.entries(configOptionValues).length === 4) {
-      this.osdRecvSpeedForm.controls.customizePriority.setValue(true);
-      return callbackFn(
-        Object({ name: 'custom', text: this.i18n('Custom'), values: configOptionValues })
-      );
-    }
-
-    return callbackFn(this.priorities[0]);
-  }
-
   onPriorityChange(selectedPriorityName) {
     const selectedPriority =
       _.find(this.priorities, (p) => {
         return p.name === selectedPriorityName;
       }) || this.priorities[0];
-
     this.setPriority(selectedPriority);
   }
 
diff --git a/src/pybind/mgr/dashboard/frontend/src/locale/messages.xlf b/src/pybind/mgr/dashboard/frontend/src/locale/messages.xlf
index 021d0741585..8c73162c673 100644
--- a/src/pybind/mgr/dashboard/frontend/src/locale/messages.xlf
+++ b/src/pybind/mgr/dashboard/frontend/src/locale/messages.xlf
@@ -863,7 +863,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.html</context>
-          <context context-type="linenumber">78</context>
+          <context context-type="linenumber">79</context>
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">app/ceph/cluster/osd/osd-reweight-modal/osd-reweight-modal.component.html</context>
@@ -919,7 +919,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.html</context>
-          <context context-type="linenumber">74</context>
+          <context context-type="linenumber">75</context>
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">app/ceph/cluster/osd/osd-scrub-modal/osd-scrub-modal.component.html</context>
@@ -951,7 +951,7 @@
         <source>This field is required!</source>
         <context-group purpose="location">
           <context context-type="sourcefile">app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.html</context>
-          <context context-type="linenumber">66</context>
+          <context context-type="linenumber">67</context>
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">app/ceph/pool/erasure-code-profile-form/erasure-code-profile-form.component.html</context>
-- 
2.39.5