From 49414ce7d1c9fdcf379860d3edab0647eae3861f Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Mon, 26 Sep 2011 11:44:58 +0000 Subject: [PATCH] xfstests: fix test 259 Move the assignment of testfile after the sourcing of the common.* files to make sure TEST_DIR is already defined - without this we end up creating the file on the root filesystem, which may not support large enough files. Also add a sync after the mkfs.xfs invocation, as losetup -d might fail the loop device deletion with -EBUSY otherwise. Signed-off-by: Christoph Hellwig Signed-off-by: Alex Elder --- 259 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/259 b/259 index a010667c..6a91cba2 100644 --- a/259 +++ b/259 @@ -29,8 +29,6 @@ echo "QA output created by $seq" status=1 # failure is the default! -testfile=$TEST_DIR/259.image - _cleanup() { rm -f "$testfile" @@ -45,6 +43,8 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 _supported_fs xfs _supported_os Linux +testfile=$TEST_DIR/259.image + # Test various sizes slightly less than 4 TB # 4398046511103 = 2^42 - 1 # 4398046510592 = 2^42 - 512 @@ -63,6 +63,7 @@ do lofile=$(losetup -f) losetup $lofile "$testfile" "$MKFS_XFS_PROG" -b size=512 $lofile >/dev/null || echo "mkfs failed!" + sync losetup -d $lofile done -- 2.39.5