From 49cc45afe88680b68717b759f63e6feeb4a9988b Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 19 Mar 2025 09:52:18 +0800 Subject: [PATCH] libcephfs_proxy: remove redundant unsigned >= 0 comparison Fix a clang warning in proxy_async.c where an unsigned value was being unnecessarily compared against 0: ``` /home/kefu/dev/ceph/src/libcephfs_proxy/proxy_async.c:29:12: warning: result of comparison of unsigned expression >= 0 is always true [-Wtautological-unsigned-zero-compare] 29 | if ((size >= 0) && !info->write) { | ~~~~ ^ ~ 1 warning generated. ``` Since unsigned values are always >= 0 by definition, remove this tautological check to resolve the "-Wtautological-unsigned-zero-compare" warning. Signed-off-by: Kefu Chai --- src/libcephfs_proxy/proxy_async.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcephfs_proxy/proxy_async.c b/src/libcephfs_proxy/proxy_async.c index 629a9feda5d..9efe0ff0faf 100644 --- a/src/libcephfs_proxy/proxy_async.c +++ b/src/libcephfs_proxy/proxy_async.c @@ -26,7 +26,7 @@ static int32_t libcephfsd_cbk_nonblocking_rw(proxy_async_t *async, info->result = cbk->ll_nonblocking_rw.res; - if ((size >= 0) && !info->write) { + if (!info->write) { iov = info->iov; count = info->iovcnt; while (size > 0) { -- 2.39.5