From 49fd336522f2a3a2ba180ca43c6f82b4ced427b9 Mon Sep 17 00:00:00 2001 From: Jos Collin Date: Fri, 19 May 2017 16:42:03 +0530 Subject: [PATCH] test/crush: silence warnings from -Walloc-size-larger-than= and -Wstringop-overflow= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The following warnings appear during make: /home/jcollin/workspace/ceph/src/test/crush/CrushWrapper.cc: In member function ‘virtual void CrushWrapper_choose_args_compat_Test::TestBody()’: /home/jcollin/workspace/ceph/src/test/crush/CrushWrapper.cc:1057:20: warning: argument 1 value ‘18446744073709550912’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=] crush_choose_arg choose_args[c.get_max_buckets()]; ^~~~~~~~~~~ In function ‘void* memset(void*, int, size_t)’, inlined from ‘virtual void CrushWrapper_choose_args_compat_Test::TestBody()’ at /home/jcollin/workspace/ceph/src/test/crush/CrushWrapper.cc:1058:9: /usr/include/bits/string3.h:90:70: warning: ‘void* __builtin_memset(void*, int, long unsigned int)’: specified size 18446744073709550912 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=] return __builtin___memset_chk (__dest, __ch, __len, __bos0 (__dest)); Signed-off-by: Jos Collin --- src/test/crush/CrushWrapper.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/test/crush/CrushWrapper.cc b/src/test/crush/CrushWrapper.cc index 559171bc0a032..816460d67963e 100644 --- a/src/test/crush/CrushWrapper.cc +++ b/src/test/crush/CrushWrapper.cc @@ -1054,8 +1054,10 @@ TEST(CrushWrapper, choose_args_compat) { crush_weight_set weight_set; weight_set.size = 1; weight_set.weights = &weights; - crush_choose_arg choose_args[c.get_max_buckets()]; - memset(choose_args, '\0', sizeof(crush_choose_arg) * c.get_max_buckets()); + int maxbuckets = c.get_max_buckets(); + assert(maxbuckets > 0); + crush_choose_arg choose_args[maxbuckets]; + memset(choose_args, '\0', sizeof(crush_choose_arg) * maxbuckets); choose_args[-1-id].ids_size = 0; choose_args[-1-id].weight_set_size = 1; choose_args[-1-id].weight_set = &weight_set; -- 2.39.5