From 4a41d3d24b86382938232afd5c07c65974c66720 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Wed, 30 Oct 2013 13:20:46 -0700 Subject: [PATCH] os/chain_listxattr: fix leak fix e22347df3854a5c5ebc6631c62d70447d67d722d added a bad goto; just free explicitly instead. Signed-off-by: Sage Weil Reviewed-by: Noah Watkins --- src/os/chain_xattr.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/os/chain_xattr.cc b/src/os/chain_xattr.cc index 52ae8dba868f9..8ca815689ed36 100644 --- a/src/os/chain_xattr.cc +++ b/src/os/chain_xattr.cc @@ -354,8 +354,10 @@ int chain_listxattr(const char *fn, char *names, size_t len) { return -ENOMEM; r = sys_listxattr(fn, full_buf, total_len); - if (r < 0) - goto done; + if (r < 0) { + free(full_buf); + return r; + } char *p = full_buf; const char *end = full_buf + r; -- 2.39.5