From 4b59316ececa60bf4c4fd1752cf159a5f035c3d6 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Mon, 31 Dec 2018 16:07:26 +0800 Subject: [PATCH] task/install: assert on installed_version > downgrade_version Signed-off-by: Kefu Chai --- teuthology/task/install/rpm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/teuthology/task/install/rpm.py b/teuthology/task/install/rpm.py index 8837a08737..5be0659e08 100644 --- a/teuthology/task/install/rpm.py +++ b/teuthology/task/install/rpm.py @@ -127,7 +127,7 @@ def _downgrade_packages(ctx, remote, pkgs, pkg_version, config): first_pkg = downgrade_pkgs[0] installed_version = packaging.get_package_version(remote, first_pkg) assert installed_version, "failed to get version of {}".format(first_pkg) - assert LooseVersion(installed_version) < LooseVersion(pkg_version) + assert LooseVersion(installed_version) > LooseVersion(pkg_version) # to compose package name like "librados2-0.94.10-87.g116a558.el7" pkgs_opt = ['-'.join([pkg, pkg_version]) for pkg in downgrade_pkgs] remote.run(args='sudo yum -y downgrade {}'.format(' '.join(pkgs_opt))) -- 2.39.5