From 4ba70f8fb4bd81cd7fd5c162e4c48d144b3368ff Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Thu, 16 May 2013 15:56:12 +0200 Subject: [PATCH] librbd/internal.cc: fix resource leak Call release() on librados::AioCompletion to free storage before leave the loop or call new again. CID 1021213 (#1 of 1): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "rados_completion" going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf --- src/librbd/internal.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/librbd/internal.cc b/src/librbd/internal.cc index d845886b25f92..d4a25e1ed8a07 100644 --- a/src/librbd/internal.cc +++ b/src/librbd/internal.cc @@ -345,6 +345,7 @@ namespace librbd { ictx->data_ctx.aio_operate(oid, rados_completion, &op); ldout(cct, 10) << "scheduling selfmanaged_snap_rollback on " << oid << " to " << snap_id << dendl; + rados_completion->release(); prog_ctx.update_progress(i * bsize, numseg * bsize); } -- 2.39.5