From 4c3e443b732f74efabf3855a3f1a21ad07053f84 Mon Sep 17 00:00:00 2001 From: Nizamudeen A Date: Mon, 16 Jun 2025 10:20:45 +0530 Subject: [PATCH] mgr/dashboard: bump node to 20.18.1 one of the inner dependency expects it ``` npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: 'undici@7.10.0', npm WARN EBADENGINE required: { node: '>=20.18.1' }, npm WARN EBADENGINE current: { node: 'v20.13.1', npm: '10.5.2' } npm WARN EBADENGINE } ``` Fixes: https://tracker.ceph.com/issues/70934 Signed-off-by: Nizamudeen A --- doc/dev/developer_guide/dash-devel.rst | 2 +- make-dist | 2 +- src/pybind/mgr/dashboard/frontend/.nvmrc | 2 +- src/pybind/mgr/dashboard/frontend/CMakeLists.txt | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/dev/developer_guide/dash-devel.rst b/doc/dev/developer_guide/dash-devel.rst index 9b02e25dfc4a3..8b2db7d7c188a 100644 --- a/doc/dev/developer_guide/dash-devel.rst +++ b/doc/dev/developer_guide/dash-devel.rst @@ -211,7 +211,7 @@ The build process is based on `Node.js `_ and requires the Prerequisites ~~~~~~~~~~~~~ - * Node 20.13.1 or higher + * Node 20.18.1 or higher * NPM 10.5.2 or higher nodeenv: diff --git a/make-dist b/make-dist index 86a9f85490e99..c7967fea24b2a 100755 --- a/make-dist +++ b/make-dist @@ -133,7 +133,7 @@ build_dashboard_frontend() { $CURR_DIR/src/tools/setup-virtualenv.sh $TEMP_DIR $TEMP_DIR/bin/pip install nodeenv - $TEMP_DIR/bin/nodeenv --verbose -p --node=20.13.1 + $TEMP_DIR/bin/nodeenv --verbose -p --node=20.18.1 cd src/pybind/mgr/dashboard/frontend . $TEMP_DIR/bin/activate diff --git a/src/pybind/mgr/dashboard/frontend/.nvmrc b/src/pybind/mgr/dashboard/frontend/.nvmrc index 9bcccb9439d9f..e8aa644174705 100644 --- a/src/pybind/mgr/dashboard/frontend/.nvmrc +++ b/src/pybind/mgr/dashboard/frontend/.nvmrc @@ -1 +1 @@ -v20.13.1 +v20.18.1 diff --git a/src/pybind/mgr/dashboard/frontend/CMakeLists.txt b/src/pybind/mgr/dashboard/frontend/CMakeLists.txt index ab4aa689385f2..9e99ba9555121 100644 --- a/src/pybind/mgr/dashboard/frontend/CMakeLists.txt +++ b/src/pybind/mgr/dashboard/frontend/CMakeLists.txt @@ -64,7 +64,7 @@ else(WITH_SYSTEM_NPM) OUTPUT "${mgr-dashboard-nodeenv-dir}/bin/npm" COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh --python=${MGR_PYTHON_EXECUTABLE} ${mgr-dashboard-nodeenv-dir} COMMAND ${mgr-dashboard-nodeenv-dir}/bin/pip install nodeenv - COMMAND ${mgr-dashboard-nodeenv-dir}/bin/nodeenv --verbose ${node_mirror_opt} -p --node=20.13.1 + COMMAND ${mgr-dashboard-nodeenv-dir}/bin/nodeenv --verbose ${node_mirror_opt} -p --node=20.18.1 # ensure that the files that nodeenv unpacks from tarballs are owned by # the current user. This can be an issue due to the node tarball using # uid 1000 and running the unpack in a id-mapped namespace (container) -- 2.39.5