From 4c760019613a39d8dc950358f727a7398fd5fea0 Mon Sep 17 00:00:00 2001 From: Daniel Marks Date: Sun, 27 Nov 2016 14:16:36 +0100 Subject: [PATCH] Better --check compatibility for ceph-restapi role Carefully chosen "always_run: true" parameters for read-only tasks that register variables. This enables --check runs (at least on deployed clusters). --- roles/ceph-restapi/tasks/docker/dirs_permissions.yml | 1 + roles/ceph-restapi/tasks/docker/fetch_configs.yml | 1 + roles/ceph-restapi/tasks/docker/main.yml | 1 + roles/ceph-restapi/tasks/start_restapi.yml | 1 + 4 files changed, 4 insertions(+) diff --git a/roles/ceph-restapi/tasks/docker/dirs_permissions.yml b/roles/ceph-restapi/tasks/docker/dirs_permissions.yml index 9d4f7da24..e291f61d1 100644 --- a/roles/ceph-restapi/tasks/docker/dirs_permissions.yml +++ b/roles/ceph-restapi/tasks/docker/dirs_permissions.yml @@ -4,6 +4,7 @@ changed_when: false failed_when: false run_once: true + always_run: true register: ceph_version - set_fact: diff --git a/roles/ceph-restapi/tasks/docker/fetch_configs.yml b/roles/ceph-restapi/tasks/docker/fetch_configs.yml index ac369b384..6515830e7 100644 --- a/roles/ceph-restapi/tasks/docker/fetch_configs.yml +++ b/roles/ceph-restapi/tasks/docker/fetch_configs.yml @@ -12,6 +12,7 @@ become: false ignore_errors: true register: statconfig + always_run: true - name: try to fetch ceph config and keys copy: diff --git a/roles/ceph-restapi/tasks/docker/main.yml b/roles/ceph-restapi/tasks/docker/main.yml index 31b44ce9b..e028a5d60 100644 --- a/roles/ceph-restapi/tasks/docker/main.yml +++ b/roles/ceph-restapi/tasks/docker/main.yml @@ -2,6 +2,7 @@ - name: check if it is Atomic host stat: path=/run/ostree-booted register: stat_ostree + always_run: true - name: set fact for using Atomic host set_fact: diff --git a/roles/ceph-restapi/tasks/start_restapi.yml b/roles/ceph-restapi/tasks/start_restapi.yml index 18a7f5864..4eef1d65e 100644 --- a/roles/ceph-restapi/tasks/start_restapi.yml +++ b/roles/ceph-restapi/tasks/start_restapi.yml @@ -3,6 +3,7 @@ shell: "pgrep ceph-rest-api" changed_when: false failed_when: false + always_run: true register: restapi_status - name: start ceph rest api -- 2.39.5