From 4d9d0ffb892b69baa54316f0102f2f4f89666a90 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Mon, 15 Jul 2013 16:12:50 -0700 Subject: [PATCH] mon/OSDMonitor: return error if we can't set the new bucket's name Signed-off-by: Sage Weil Reviewed-by: Dan Mick --- src/mon/OSDMonitor.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc index 7e76ea271c40d..8a3a4f0422bd4 100644 --- a/src/mon/OSDMonitor.cc +++ b/src/mon/OSDMonitor.cc @@ -2647,7 +2647,11 @@ bool OSDMonitor::prepare_command(MMonCommand *m) int bucketno = newcrush.add_bucket(0, CRUSH_BUCKET_STRAW, CRUSH_HASH_DEFAULT, type, 0, NULL, NULL); - newcrush.set_item_name(bucketno, name); + err = newcrush.set_item_name(bucketno, name); + if (err < 0) { + ss << "error setting bucket name to '" << name << "'"; + goto reply; + } pending_inc.crush.clear(); newcrush.encode(pending_inc.crush); -- 2.39.5