From 4e2ca4dcfcdc80c5fdbfa622ad7cb094dd1c281d Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Wed, 31 Jan 2018 09:31:11 +0100 Subject: [PATCH] common: do not use `shell` module when it is not needed MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There is no need here to use `shell` instead of `command` Signed-off-by: Guillaume Abrioux (cherry picked from commit dd0c98c5a2e9e26bca60e00564ea2018984545f6) Signed-off-by: Sébastien Han --- infrastructure-playbooks/purge-cluster.yml | 8 ++++++-- roles/ceph-common/tasks/checks/check_firewall.yml | 4 +++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/infrastructure-playbooks/purge-cluster.yml b/infrastructure-playbooks/purge-cluster.yml index c04c408a5..e2b1478c2 100644 --- a/infrastructure-playbooks/purge-cluster.yml +++ b/infrastructure-playbooks/purge-cluster.yml @@ -288,7 +288,9 @@ ignore_errors: true - name: is reboot needed - local_action: shell echo requesting reboot + local_action: + module: command + echo requesting reboot become: false notify: - restart machine @@ -563,7 +565,9 @@ state: absent - name: request data removal - local_action: shell echo requesting data removal + local_action: + module: command + echo requesting data removal become: false notify: - remove data diff --git a/roles/ceph-common/tasks/checks/check_firewall.yml b/roles/ceph-common/tasks/checks/check_firewall.yml index 458da0711..15c0623d2 100644 --- a/roles/ceph-common/tasks/checks/check_firewall.yml +++ b/roles/ceph-common/tasks/checks/check_firewall.yml @@ -1,6 +1,8 @@ --- - name: check if nmap is installed - local_action: shell command -v nmap + local_action: + module: command + command -v nmap changed_when: false failed_when: false register: nmapexist -- 2.39.5