From 4f4bf266521e3045f4fa2d1f4d0e63bf1afc759c Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 11 Aug 2021 11:44:27 +0800 Subject: [PATCH] test/rgw: build without "using namespace std" * add "std::" prefix in headers * add "using" declarations in .cc files. so we don't rely on "using namespace std" in one or more included headers. Signed-off-by: Kefu Chai --- src/test/rgw/test_http_manager.cc | 2 ++ src/test/rgw/test_rgw_bencode.cc | 2 ++ src/test/rgw/test_rgw_lua.cc | 1 + src/test/rgw/test_rgw_period_history.cc | 1 + 4 files changed, 6 insertions(+) diff --git a/src/test/rgw/test_http_manager.cc b/src/test/rgw/test_http_manager.cc index 3ecd01d9f18..599266731d8 100644 --- a/src/test/rgw/test_http_manager.cc +++ b/src/test/rgw/test_http_manager.cc @@ -21,6 +21,8 @@ #include #include +using namespace std; + TEST(HTTPManager, ReadTruncated) { using tcp = boost::asio::ip::tcp; diff --git a/src/test/rgw/test_rgw_bencode.cc b/src/test/rgw/test_rgw_bencode.cc index 66fa92a8a17..a6ba793944b 100644 --- a/src/test/rgw/test_rgw_bencode.cc +++ b/src/test/rgw/test_rgw_bencode.cc @@ -4,6 +4,8 @@ #include "rgw/rgw_torrent.h" +using namespace std; + TEST(Bencode, String) { TorrentBencode decode; diff --git a/src/test/rgw/test_rgw_lua.cc b/src/test/rgw/test_rgw_lua.cc index d8cc355c630..f9459e1146e 100644 --- a/src/test/rgw/test_rgw_lua.cc +++ b/src/test/rgw/test_rgw_lua.cc @@ -6,6 +6,7 @@ #include "rgw/rgw_sal_rados.h" #include "rgw/rgw_lua_request.h" +using namespace std; using namespace rgw; using boost::container::flat_set; using rgw::auth::Identity; diff --git a/src/test/rgw/test_rgw_period_history.cc b/src/test/rgw/test_rgw_period_history.cc index a4854ea778f..39c173ac430 100644 --- a/src/test/rgw/test_rgw_period_history.cc +++ b/src/test/rgw/test_rgw_period_history.cc @@ -19,6 +19,7 @@ #include #include +using namespace std; namespace { // construct a period with the given fields -- 2.39.5