From 4fc9428506072705c5e7d5456b81b02ac6661a5e Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Thu, 30 Oct 2014 05:16:34 +0100 Subject: [PATCH] osd/ReplicatedPG.cc: remove redundant check Fix for: [src/osd/ReplicatedPG.cc:2171]: (style) Redundant checking of STL container element existence before removing it. Signed-off-by: Danny Al-Gaaf --- src/osd/ReplicatedPG.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/osd/ReplicatedPG.cc b/src/osd/ReplicatedPG.cc index d6ecd9473cfd8..55adf12a9f59f 100644 --- a/src/osd/ReplicatedPG.cc +++ b/src/osd/ReplicatedPG.cc @@ -2326,9 +2326,7 @@ void ReplicatedPG::do_scan( } peer_backfill_info[from] = bi; - if (waiting_on_backfill.find(from) != waiting_on_backfill.end()) { - waiting_on_backfill.erase(from); - + if (waiting_on_backfill.erase(from)) { if (waiting_on_backfill.empty()) { assert(peer_backfill_info.size() == backfill_targets.size()); finish_recovery_op(hobject_t::get_max()); -- 2.39.5