From 5018cd1c0f9f08f18c13b9e2c75cc9d8e214ddc4 Mon Sep 17 00:00:00 2001 From: Amir Goldstein Date: Mon, 14 May 2018 08:49:51 +0300 Subject: [PATCH] generic: test first read with freeze right after mount With ext4, this leads to freeze proection bypass WARN_ON in ext4_journal_check_start. Signed-off-by: Amir Goldstein Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- tests/generic/491 | 75 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/491.out | 2 ++ tests/generic/group | 1 + 3 files changed, 78 insertions(+) create mode 100755 tests/generic/491 create mode 100644 tests/generic/491.out diff --git a/tests/generic/491 b/tests/generic/491 new file mode 100755 index 00000000..57f02459 --- /dev/null +++ b/tests/generic/491 @@ -0,0 +1,75 @@ +#! /bin/bash +# FS QA Test No. 491 +# +# Test first read with freeze right after mount. +# +# With ext4, this leads to freeze proection bypass WARN_ON in +# ext4_journal_check_start. +# +#----------------------------------------------------------------------- +# Copyright (C) 2018 CTERA Networks. All Rights Reserved. +# Author: Amir Goldstein +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs generic +_supported_os Linux +_require_scratch +_require_freeze +_require_command "$TIMEOUT_PROG" "timeout" + +rm -f $seqres.full + +testfile=$SCRATCH_MNT/foo + +# Create a filesystem with a file +_scratch_mkfs >>$seqres.full 2>&1 +_scratch_mount +echo "frozen" > $testfile + +# Mount filesystem "noatime" and freeze right after mount - +# reads should not block +_scratch_cycle_mount "noatime" +xfs_freeze -f $SCRATCH_MNT + +# Read file while filesystem is frozen should succeed +# without blocking +$TIMEOUT_PROG -s KILL 1s cat $testfile + +xfs_freeze -u $SCRATCH_MNT + +status=0 +exit diff --git a/tests/generic/491.out b/tests/generic/491.out new file mode 100644 index 00000000..0b197852 --- /dev/null +++ b/tests/generic/491.out @@ -0,0 +1,2 @@ +QA output created by 491 +frozen diff --git a/tests/generic/group b/tests/generic/group index 86449179..4fc3e457 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -493,3 +493,4 @@ 488 auto quick 489 auto quick attr 490 auto quick rw +491 auto quick freeze mount -- 2.39.5