From 501e33bc6a023eaaa537336a44513f1b9d62fe62 Mon Sep 17 00:00:00 2001 From: Dimitri Savineau Date: Tue, 12 Jan 2021 14:29:58 -0500 Subject: [PATCH] container/registry: use password from stdin Pass the password variable via stdin for the registry login authentication. This allows to remove the no_log statement and see the task output without displaying the password value. Signed-off-by: Dimitri Savineau (cherry picked from commit a0e1a450d3cbdcd52a39bd11fd9b8287daabae1f) --- roles/ceph-container-common/tasks/registry.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/roles/ceph-container-common/tasks/registry.yml b/roles/ceph-container-common/tasks/registry.yml index 4fa2715b1..03d00a70c 100644 --- a/roles/ceph-container-common/tasks/registry.yml +++ b/roles/ceph-container-common/tasks/registry.yml @@ -1,8 +1,10 @@ --- - name: container registry authentication - command: '{{ container_binary }} login -u {{ ceph_docker_registry_username }} -p {{ ceph_docker_registry_password | quote }} {{ ceph_docker_registry }}' + command: '{{ container_binary }} login -u {{ ceph_docker_registry_username }} --password-stdin {{ ceph_docker_registry }}' + args: + stdin: '{{ ceph_docker_registry_password }}' + stdin_add_newline: no changed_when: false - no_log: true environment: HTTP_PROXY: "{{ ceph_docker_http_proxy | default('') }}" HTTPS_PROXY: "{{ ceph_docker_https_proxy | default('') }}" -- 2.39.5