From 507797ea24ddf1a772df5aa86536d212acbc53cd Mon Sep 17 00:00:00 2001 From: xie xingguo Date: Mon, 24 Jul 2017 16:28:13 +0800 Subject: [PATCH] mon/PGMap: fix condition checking for slow-requests op_queue_age_hist collects op stats in ms, not sec. Signed-off-by: xie xingguo --- src/mon/PGMap.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mon/PGMap.cc b/src/mon/PGMap.cc index b907003c6d5..076c618ce84 100644 --- a/src/mon/PGMap.cc +++ b/src/mon/PGMap.cc @@ -3054,7 +3054,8 @@ void PGMap::get_health_checks( // REQUEST_SLOW // REQUEST_STUCK if (cct->_conf->mon_osd_warn_op_age > 0 && - osd_sum.op_queue_age_hist.upper_bound() > + !osd_sum.op_queue_age_hist.h.empty() && + osd_sum.op_queue_age_hist.upper_bound() / 1000.0 > cct->_conf->mon_osd_warn_op_age) { list warn_detail, error_detail; unsigned warn = 0, error = 0; @@ -3364,7 +3365,8 @@ void PGMap::get_health( // slow requests if (cct->_conf->mon_osd_warn_op_age > 0 && - osd_sum.op_queue_age_hist.upper_bound() > cct->_conf->mon_osd_warn_op_age) { + osd_sum.op_queue_age_hist.upper_bound() / 1000.0 > + cct->_conf->mon_osd_warn_op_age) { auto sum = _warn_slow_request_histogram( cct, osd_sum.op_queue_age_hist, "", summary, NULL); if (sum.first > 0 || sum.second > 0) { -- 2.39.5