From 5108860c385cc1d905588d2e92d80295e3222ca4 Mon Sep 17 00:00:00 2001 From: xie xingguo Date: Sat, 30 Mar 2019 11:26:19 +0800 Subject: [PATCH] mgr/BaseMgrModule: drop GIL in ceph_store_set Signed-off-by: xie xingguo --- src/mgr/ActivePyModules.cc | 3 --- src/mgr/BaseMgrModule.cc | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mgr/ActivePyModules.cc b/src/mgr/ActivePyModules.cc index 0f3f508eb6f..745a34e301b 100644 --- a/src/mgr/ActivePyModules.cc +++ b/src/mgr/ActivePyModules.cc @@ -593,10 +593,7 @@ void ActivePyModules::set_store(const std::string &module_name, Command set_cmd; { - PyThreadState *tstate = PyEval_SaveThread(); std::lock_guard l(lock); - PyEval_RestoreThread(tstate); - if (val) { store_cache[global_key] = *val; } else { diff --git a/src/mgr/BaseMgrModule.cc b/src/mgr/BaseMgrModule.cc index 87eda069d50..1cdb0f09a81 100644 --- a/src/mgr/BaseMgrModule.cc +++ b/src/mgr/BaseMgrModule.cc @@ -483,7 +483,9 @@ ceph_store_set(BaseMgrModule *self, PyObject *args) if (value) { val = value; } + PyThreadState *tstate = PyEval_SaveThread(); self->py_modules->set_store(self->this_module->get_name(), key, val); + PyEval_RestoreThread(tstate); Py_RETURN_NONE; } -- 2.39.5