From 5132a1ce3845bd217fe4e35d33d9ffa3ac908c0f Mon Sep 17 00:00:00 2001 From: Brad Hubbard Date: Wed, 3 Jan 2018 13:06:26 +1000 Subject: [PATCH] mds: Remove redundant null pointer check Resolves Coverity CID 1426746 Signed-off-by: Brad Hubbard --- src/mds/MDBalancer.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/mds/MDBalancer.cc b/src/mds/MDBalancer.cc index 14b930c8a6e..4801f8f5abf 100644 --- a/src/mds/MDBalancer.cc +++ b/src/mds/MDBalancer.cc @@ -1269,11 +1269,9 @@ int MDBalancer::dump_loads(Formatter *f) CDir *dir = dfs.front(); dfs.pop_front(); - if (f) { - f->open_object_section("dir"); - dir->dump_load(f, now, decayrate); - f->close_section(); - } + f->open_object_section("dir"); + dir->dump_load(f, now, decayrate); + f->close_section(); for (CDir::map_t::iterator it = dir->begin(); it != dir->end(); ++it) { CInode *in = it->second->get_linkage()->get_inode(); -- 2.39.5