From 52a3700b26e15a7267527463766ef1f22768ae25 Mon Sep 17 00:00:00 2001 From: Nikolay Borisov Date: Tue, 23 Feb 2021 17:50:42 +0200 Subject: [PATCH] btrfs: Add simple stress test when qgroup limits are reached This test uncovered 2 deadlocks with qgroups when their limit was reached. Signed-off-by: Nikolay Borisov Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- tests/btrfs/232 | 73 +++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/232.out | 2 ++ tests/btrfs/group | 1 + 3 files changed, 76 insertions(+) create mode 100755 tests/btrfs/232 create mode 100644 tests/btrfs/232.out diff --git a/tests/btrfs/232 b/tests/btrfs/232 new file mode 100755 index 00000000..b0a04a61 --- /dev/null +++ b/tests/btrfs/232 @@ -0,0 +1,73 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2021 SUSE Linux Products GmbH. All Rights Reserved. +# +# FS QA Test 232 +# +# Test that performing io and exhausting qgroup limit won't deadlock. This +# exercises issues fixed by the following kernel commits: +# +# 4f6a49de64fd ("btrfs: unlock extents in btrfs_zero_range in case of quota +# reservation errors") +# 4d14c5cde5c2 ("btrfs: don't flush from btrfs_delayed_inode_reserve_metadata") +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +writer() +{ + while true; do + args=`_scale_fsstress_args -p 20 -n 1000 $FSSTRESS_AVOID -d $SCRATCH_MNT/stressdir` + $FSSTRESS_PROG $args >/dev/null 2>&1 + done +} + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs btrfs + +_require_scratch_size $((2 * 1024 * 1024)) +_scratch_mkfs > /dev/null 2>&1 +_scratch_mount + +_pwrite_byte 0xcd 0 900m $SCRATCH_MNT/file >> $seqres.full +# Make sure the data reach disk so later qgroup scan can see it +sync + +$BTRFS_UTIL_PROG quota enable $SCRATCH_MNT +$BTRFS_UTIL_PROG quota rescan -w $SCRATCH_MNT >> $seqres.full +# set the limit to 1 g, leaving us just 100mb of slack space +$BTRFS_UTIL_PROG qgroup limit 1G 0/5 $SCRATCH_MNT + +writer & +writer_pid=$! + +# Give time for the background thread to generate some load +sleep 30 + +kill $writer_pid +wait + +# success, all done +echo "Silence is golden" +status=0 +exit diff --git a/tests/btrfs/232.out b/tests/btrfs/232.out new file mode 100644 index 00000000..930bbb4d --- /dev/null +++ b/tests/btrfs/232.out @@ -0,0 +1,2 @@ +QA output created by 232 +Silence is golden diff --git a/tests/btrfs/group b/tests/btrfs/group index 224f3d62..c0d7a53c 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -234,3 +234,4 @@ 229 auto quick send clone 230 auto quick qgroup limit 231 auto quick clone log replay +232 auto quick qgroup limit -- 2.39.5