From 53be0980be65170bb4f2acb3c87b0c1eff8c7acb Mon Sep 17 00:00:00 2001 From: =?utf8?q?S=C3=A9bastien=20Han?= Date: Mon, 15 May 2017 10:56:33 +0200 Subject: [PATCH] generate_group_vars_sample: do not use expr MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit As mentionned in https://github.com/koalaman/shellcheck/wiki/SC2003 expr is antiquated. Signed-off-by: Sébastien Han --- generate_group_vars_sample.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generate_group_vars_sample.sh b/generate_group_vars_sample.sh index c238d8cda..e42253858 100755 --- a/generate_group_vars_sample.sh +++ b/generate_group_vars_sample.sh @@ -36,7 +36,7 @@ EOF sed '/^---/d; s/^\([A-Za-z[:space:]]\)/#\1/' \ "$defaults" >> "$basedir"/group_vars/"$output" echo >> "$basedir"/group_vars/"$output" - elif [ "$(expr substr $(uname -s) 1 5)" == "Linux" ]; then + elif [ "$(uname -s)" == "Linux" ]; then sed '/^---/d; s/^\([A-Za-z[:space:]].\+\)/#\1/' \ "$defaults" >> "$basedir"/group_vars/"$output" echo >> "$basedir"/group_vars/"$output" -- 2.39.5