From 552d85a4a8bfa59347fdf4741b2883957d4bc620 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Mon, 24 Nov 2008 10:27:22 -0800 Subject: [PATCH] osd: add a few getattr assertions Ensure we got the snapset attr before we decode it. --- src/osd/ReplicatedPG.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/osd/ReplicatedPG.cc b/src/osd/ReplicatedPG.cc index 98343071e30a6..10e4f40120635 100644 --- a/src/osd/ReplicatedPG.cc +++ b/src/osd/ReplicatedPG.cc @@ -2012,7 +2012,8 @@ void ReplicatedPG::push_to_replica(pobject_t poid, int peer) } bufferlist bl; - osd->store->getattr(info.pgid.to_coll(), head, "snapset", bl); + r = osd->store->getattr(info.pgid.to_coll(), head, "snapset", bl); + assert(r >= 0); bufferlist::iterator blp = bl.begin(); SnapSet snapset; ::decode(snapset, blp); @@ -2024,7 +2025,8 @@ void ReplicatedPG::push_to_replica(pobject_t poid, int peer) // pushing head. // base this on partially on replica's clones? bufferlist bl; - osd->store->getattr(info.pgid.to_coll(), poid, "snapset", bl); + int r = osd->store->getattr(info.pgid.to_coll(), poid, "snapset", bl); + assert(r >= 0); bufferlist::iterator blp = bl.begin(); SnapSet snapset; ::decode(snapset, blp); -- 2.39.5