From 56504d2ad92b39c9b92134bec9cbe83f94ddca3f Mon Sep 17 00:00:00 2001 From: Igor Fedotov Date: Mon, 22 Jul 2024 17:15:45 +0300 Subject: [PATCH] kv/rocksdb: return error for dump_objectstore_kv_stats asok command if relevant config settings result in no output. Signed-off-by: Igor Fedotov --- src/kv/RocksDBStore.cc | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/kv/RocksDBStore.cc b/src/kv/RocksDBStore.cc index a653fa6398c..bef87d15ed7 100644 --- a/src/kv/RocksDBStore.cc +++ b/src/kv/RocksDBStore.cc @@ -1417,8 +1417,13 @@ int64_t RocksDBStore::estimate_prefix_size(const string& prefix, void RocksDBStore::get_statistics(Formatter *f) { if (!cct->_conf->rocksdb_perf) { - dout(20) << __func__ << " RocksDB perf is disabled, can't probe for stats" - << dendl; + f->write_raw_data("error: RocksDB perf is disabled, can't probe for stats.\n"); + return; + } + if (!cct->_conf->rocksdb_collect_compaction_stats && + !cct->_conf->rocksdb_collect_extended_stats && + !cct->_conf->rocksdb_collect_memory_stats) { + f->write_raw_data("error: None of rocksdb_collect_* setting is enabled, hence no output.\n"); return; } -- 2.39.5